cornerstone icon indicating copy to clipboard operation
cornerstone copied to clipboard

Consider implementing typescript

Open LordZardeck opened this issue 2 years ago • 4 comments

It would be nice if the project was built on TypeScript. This could even be a gradual thing until the entire project moves to it. Would PRs be accepted for migrating the project to TypeScript?

LordZardeck avatar Aug 01 '22 19:08 LordZardeck

hi @LordZardeck Thanks for idea. Migrating Cornerstone to TypeScript requires big effort and currently BigCommerce is not planning it. However we consider using TypeScript for developing future themes.

BC-krasnoshapka avatar Aug 02 '22 12:08 BC-krasnoshapka

@BC-krasnoshapka Does that mean you wouldn’t accept PRs to move it towards typescript?

LordZardeck avatar Aug 02 '22 14:08 LordZardeck

any plans to provide a base template for Headless commerce using Next.js? Similar to cornerstone theme

rajguru827 avatar Aug 02 '22 16:08 rajguru827

@LordZardeck besides converting code to TS effort also consist of testing and fixing possible issues. BigCommerce can't guarantee we support this, at least this year. Besides that Cornerstone has 500+ forks. Usually developers receive regular updates in their themes by merging changes into their forks, that may have overrides. Converting to TS and merging it into forks will require huge effort from community as well. Even though TS has its benefits we haven't heard huge demand on TS in Cornerstone from community. Maybe there will be more feedback in this issue, let's see.

BC-krasnoshapka avatar Sep 07 '22 12:09 BC-krasnoshapka