cornerstone
cornerstone copied to clipboard
bigcommerce
Revert "Reset cart quantity to 0 if we get a 404 for the cart"
What?
This reverts commit caa1b30580f1a3c527de5d9b499d168c4cb96e86.
I noticed issues on my site where the cart quantity was not updating correctly. I dug into this and found that this is likely due to the 404 for the cart page no longer being handled correctly after the move from jquery to fetch.
fetch does not handle 404 as an error and requires this to be handled by consumer code. this looks to have been added in stencil utils https://github.com/bigcommerce/stencil-utils/pull/137 as part of STRF-8771 so this code in cornerstone is no longer required. the stencil-utils change should fix the type error that occurs when trying to read physicalItems of a non-existent cart. this is the error that was making it's way through to this code which is why I noticed the 404 no longer makes it through to here.
This PR has pre-requisites:
- release 6.7.0 of stencil-utils including STRF-8771
- incorporate 6.7.0 stencil-utils into cornerstone
- test any other changes thar are brought in alongside this
I'm unsure of the release process for the other libs so wasn't sure if making a PR to bump the package.json was useful or not.
Hope this helps. I'd really appreciate if we can get this into a cornerstone release soon so that our cart quantity works again!
Tickets / Documentation
Add links to any relevant tickets and documentation.
- Original PR
- Dependency in stencil-utils
- BC Support Case - 04584972 - There is a BCTHEME ticket related to this but unfortunately, the live chat log hasn't come through yet and I didn't note the Jira ticket number.
cc @jairo-bc @bookernath as you were both involved in the linked PRs. would appreciate you taking a look at this :)
@rowleyaj LGTM. I think you can bump stencil-utils version in this PR. I will handle releasing stencil-utils. cc @BC-tymurbiedukhin
@jairo-bc thanks! i've added the package.json change for that, however I won't be able to update the lock file until I can do an NPM install with the real package
Is this related?
On multiple themes, the scripts responsible for fetching cart metadata cart-preview.js is returning an error.
It's called in global.js, a CartID is injected from context and passed in to stencil utils.
The problem is - the CartID is occasionally stale if you've previously used stencil-utils to delete the cart.
This means that the call to stencil-utils getCartQuantity fails, and the stale value in the count-pill is not replaced, since it's initially set by pulling from localStorage.
@Mikhail-MM yup that's the same issue I was having. After falling down the 🐰 🕳️ an digging through the code this is where i ended up. Essentially it's fixed in stencil-utils once we import the newer version to cornerstone, this PR is just cleaning up after that fix.
@jairo-bc sorry for the delay - PR updated with 6.7.0 in the lockfile now and CI is green
@jairo-bc @BC-tymurbiedukhin @bookernath happy new year - just checking in on this one to see if we can get it merged 🤞
@jairo-bc @BC-tymurbiedukhin @bookernath fixed the conflict. a higher version of stencil-utils has been included now so the main issue should be resolved. i think this should still be merged though as it cleans up code that isn't needed anymore.
@jairo-bc @BC-tymurbiedukhin @bookernath anything else needed on this before it can be merged?
@BC-tymurbiedukhin this has been added to the changelog now. would you accept a PR to add this requirement to the pull request template and contributing guide? i've created 2080 for this
it seems that this PR was held up for quite a long time just because of this small missing piece