cornerstone icon indicating copy to clipboard operation
cornerstone copied to clipboard

feat(bctheme): BCTHEME-38 Cornerstone - Add Client Validation for Pho…

Open BC-tymurbiedukhin opened this issue 4 years ago • 4 comments

…ne Number on Account Creation/Edit Pages

What?

The new validation confirms that after removing -"_()/:#.,'*\s user input will match with E164 phone number standard, but with at least 3 numbers

Tickets / Documentation

https://jira.bigcommerce.com/browse/BCTHEME-38

Screenshots (if appropriate)

Screenshot 2020-07-15 at 16 37 23 Screenshot 2020-07-15 at 16 37 33

ping @junedkazi @yurytut1993 @bc-alexsaiannyi @golcinho

BC-tymurbiedukhin avatar Jul 15 '20 13:07 BC-tymurbiedukhin

Autotagging @bigcommerce/storefront-team @davidchin

bigbot avatar Jul 15 '20 13:07 bigbot

Pattern attribute of html5 tag isn't available to validate complex logic, I have investigated this question and found that the only way to let validation works in different countries to create custom regexp logic. Lmk if there is a workaround, I will be glad to have a look on it

BC-tymurbiedukhin avatar Jul 15 '20 13:07 BC-tymurbiedukhin

I think this will cause issues as we have some merchants who use this field to store non phone numbers. I would talk to Derrek Pearson and see if he remembers. The last time we did this on customers team it had to be rolled back as people had saved data that broke checkout.

aleachjr avatar Jul 15 '20 14:07 aleachjr

@aleachjr what is current status for this issue?

BC-tymurbiedukhin avatar Jul 27 '20 10:07 BC-tymurbiedukhin