made taxes field customizable and fixed language error in de.json

[pauliusinc]

What?

PR for customizable taxes field by language json files.

Why?

Closes: https://github.com/bigcommerce/checkout-js/issues/885

Testing / Proof

No need because few changes of strings

@bigcommerce/checkout

[bc-peng]

Hello, we're looking into the wording adjustment. Meanwhile, to pass the unit test, you need to update snapshots with this command npm run test -- -u.

[animesh1987]

Hey @pauliusinc is this still relevant?

[pauliusinc]

Hey @animesh1987,

the language tag for the taxes is not relevant anymore. This will be set at another position (in the settings of the store).

However, the subtotal text is still relevant and is wrong translated to German within the checkout, the cart page, all marketing emails and for the printable invoice from the shop orders and also for the invoice that is downloadable for the customer on the shop itself.

I wrote many scripts to correct this wrong translation in all this positions. If this could be fixed I would really appreciate that.

[animesh1987]

Thanks @pauliusinc for the feedback, seems like something that we need to work with our translation team since it seems like it's just not related to this repo but a wider issue.

I will close this PR in that case. And hopefully we can fix it at the root.

Again thanks for notifying us 🙇

[funivan]

Hi folks. We need to have an issue for this case.

[animesh1987]

Thanks @funivan

[bc-0dp]

@animesh1987 @funivan was this ticket created and rectified?

[animesh1987]

@bc-0dp seems to have been fixed https://github.com/bigcommerce/checkout-js/blob/master/packages/locale/src/translations/de.json#L77 probably via the bot.

[bc-0dp]

Hi @funivan I will close #885 for now. If this issue persists, then don't hesitate to create a new issue. ❤️