bigcommerce-for-wordpress icon indicating copy to clipboard operation
bigcommerce-for-wordpress copied to clipboard

Create CODEOWNERS and add dev-docs team

Open bookernath opened this issue 4 years ago • 5 comments

What?

Add a CODEOWNERS file and make sure @bigcommerce/dev-docs gets pinged on any changes to CHANGELOG.md (which should mostly be for new versions)

bookernath avatar Nov 25 '20 18:11 bookernath

Since packaging new releases appears to be done via hand and Pull Request, this will block those PRs from being merged until someone from the dev docs team approves them. Is that the intention?

PascalZajac avatar Nov 25 '20 22:11 PascalZajac

@PascalZajac, the Dev Docs team does not need to be designated a code owner for this repo. Watching serves our purposes well enough. Thank you for checking.

UwanaIkaiddiSonos avatar Nov 25 '20 22:11 UwanaIkaiddiSonos

CODEOWNERS can also be used to only ping certain groups, but it turns out those groups also have to have write access to the repo or it won't work.

bookernath avatar Nov 30 '20 17:11 bookernath

@bookernath welp, I'm the worst at noticing PR reviews that I'm tagged in. Apologies. Based on the above convo, is this something we still want to pursue / add? It seems like no, but I wanted to check before closing.

amckemie avatar Apr 14 '21 21:04 amckemie

@bookernath @amckemie, please disregard the dev-docs request approval. Dev-docs does not need to be a CODEOWNER for this repo.

UwanaIkaiddiSonos avatar Apr 23 '21 14:04 UwanaIkaiddiSonos