bigcommerce-api-php icon indicating copy to clipboard operation
bigcommerce-api-php copied to clipboard

Need to force string when constructing error classes

Open carsonreinke opened this issue 6 years ago • 1 comments

What?

Some responses incorrectly throw error messages because there is a type mismatch on the arguments to the error constructors. Basically, json_decode on the response body is not guaranteed to return a string. We need to enforce the string.

Writing test cases involved a lot of work unless a curl abstraction was built/used. Even mocking is extremely difficult here.

Tickets / Documentation

https://github.com/bigcommerce/bigcommerce-api-php/issues/223

Screenshots (if appropriate)

None

cc @jofomah

carsonreinke avatar Nov 04 '19 17:11 carsonreinke

Hello? @bookernath

carsonreinke avatar Mar 16 '20 20:03 carsonreinke