bigcommerce-api-php icon indicating copy to clipboard operation
bigcommerce-api-php copied to clipboard
verified publisher icon bigcommerce

Change Rule->conditions To Use Fields

Open jbutz opened this issue 8 years ago • 2 comments

What?

This pull request is mostly a duplicate of #167 expect it also fixes the failed unit tests. The Rule->conditions method should act like the Sku->options method and not pull from a resource url.

jbutz avatar Oct 01 '17 19:10 jbutz

Coverage Status

Coverage decreased (-0.06%) to 69.088% when pulling ad206eb3b19318b6d767c18fd19be4a3e99b24d4 on butztech:master into e57fc7ab2de3a5dabc047fd96fa61b2596d23089 on bigcommerce:master.

coveralls avatar Oct 01 '17 19:10 coveralls

It looks like the failing unit test has something to do with the Travis CI configuration

jbutz avatar Oct 01 '17 19:10 jbutz