greenlight
greenlight copied to clipboard
bigbluebutton
Improvement of Room Sharing capabilities (followup to #5068 static SIP pins)
Dear reviewers,
In my previous pull request (#5068), I added support for static SIP pins. To fully leverage this feature, I've implemented a share button that opens a module allowing users to easily copy the pin, corresponding SIP phone number, and meeting link to their clipboard. Additionally, I've included an option to download an .ics file to easily send the meeting information via email.
To further enhance the user interface, I've made some restructuring changes in this pull request. These changes aim to improve the overall user experience and make the UI more intuitive and user-friendly.
I appreciate your time and feedback on this pull request.
Thank you!
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
16 Code Smells
No Coverage information
0.0% Duplication
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
See analysis details on SonarCloud
@SebastianAppDev Sorry, if this question shouldn't be right here. But I would like to give your features a try. I'm running latest bigbluebutton with latest greenlight. What do I have to do or to mount to test your implementation on my server? Thanks a lot.
@SebastianAppDev Sorry, if this question shouldn't be right here. But I would like to give your features a try. I'm running latest bigbluebutton with latest greenlight. What do I have to do or to mount to test your implementation on my server? Thanks a lot.
First, ensure you've checked out the branch you intend to test. Next, you have two options: utilize Docker to build and deploy the image, or run the Rails application locally. Don't forget to set the BBB instance and the voice bridge in the environment for a comprehensive setup.
@SebastianAppDev Thanks for your information. Are there any helpful resources on how to build this docker-image? I'm completely new as admin. Generally and in theory I know how to build a docker-image. But that would be my first one in practice, and I might need some additional information about, for example what files of the branch have to be included. Or is there even a docker-image of the sip-branch on docker-hub?
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
See analysis details on SonarCloud
We tested this and noticed that the share room link is missing the relative root path. Other than that I hope this can get merged soon, this is a very useful feature.
Does this PR obsolete your former one (#5068)?
And do you intent to
- add specs for your changes?
- fix the rubocop check?
- merge upstream once more?
Hi,
This PR does not supersede #5068. This PR is only an update to the room sharing functionality, it works well with static PINs as well as without.
I am interested in doing the rest of the work. These two PRs are my first for bigger projects so some guidance on the rubocop checks and specification would be greatly appreciated.
- I can't really tell what the problem is with rubocop (it says waiting for status to be reported??).
- Where are the specs for my changes that are supposed to be documented?
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code
See analysis details on SonarCloud