greenlight icon indicating copy to clipboard operation
greenlight copied to clipboard

Access Codes: Extended the access codes fetching logic to hide the codes for forced disabled configs.

Open KH-Amir-TN opened this issue 2 years ago • 2 comments

Description

Synchronizing the rooms access codes settings with their rooms configs.

This PR:

  • Edits Rooms model to extend the access codes fetching logic to hide their values when having a forced disabled config.

Testing Steps

  1. Pull the code.
  2. Install the dependencies bundle install && npm|yarn install.
  3. Clean the previous assets build by running rm app/assets/builds/* (This won't remove .keep since it's hidden).
  4. Clean the database and tmp files for a better isolation by running rails tmp:clear && rails db:schema:cache:clear && rails db:drop && rails db:create && rails db:migrate:with_data
  5. Run the linter and specs bundle exec rubocop --parallel && bundle exec rspec && npx eslint app/javascript/* --ext .jsx,.js
  6. Run ./bin/dev to run the assets builders processes and the Puma server all at once.

Screenshots (if appropriate):

KH-Amir-TN avatar Aug 08 '22 13:08 KH-Amir-TN

REBASED ON e35a8820c41bdf1560c8e65438e8ccae4c415bc2

KH-Amir-TN avatar Aug 15 '22 17:08 KH-Amir-TN

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 15 '22 17:08 sonarqubecloud[bot]