greenlight icon indicating copy to clipboard operation
greenlight copied to clipboard

Accessibility navigate and create room

Open galupa opened this issue 3 years ago • 2 comments

Hi, This PR will enable keyboard users to be able to navigate through rooms and also create a new room. On current greenlight, keyboard user cannot create a new room, if you try to navigate using keyboards (tabs key), you will be looped on the first room link and its settings button. This PR main goal is to make keyboard user able to reach the new create room button.

Description

To do this, we change the room element from tag to

and we add some some action on it, so that enter key and escape key still works. We also add some aria-label on the tags so that screen reader can read it.

Testing Steps

To test it:

  1. Go to greenlight dashboard or room
  2. Try to open a create room modal by using only keyboard
  3. You should be able to navigate to the new create room button using only keyboard

Screenshots (if appropriate):

There should not be any changes in term of visual.

galupa avatar Jun 29 '21 04:06 galupa

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 29 '21 04:06 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

sonarqubecloud[bot] avatar Dec 23 '21 19:12 sonarqubecloud[bot]