greenlight icon indicating copy to clipboard operation
greenlight copied to clipboard

Accessibility fix for remove user access

Open galupa opened this issue 3 years ago • 6 comments

Hi, This PR should enable keyboard user (user that visually impaired) to remove user access from the Share Room Access modal. By using tabs key, the user will be able to get to x remove shared user.

Description

It is just a small changes and all changes are on share room access modal:

  1. (room.js) Change x (remove shared user) from to
  2. (locales) add remove_user so for aria-label, so screen reader can read it.

Testing Steps

To test it:

  1. Go to shared room access modal
  2. If there is no user, add a user
  3. User (you) should be able to remove the user that just added by using only keyboard, using tabs and enter / space key.

Screenshots (if appropriate):

Not much changes, but if you look closely the x button is select able by keyboard now Screenshot from 2021-06-29 15-31-27

galupa avatar Jun 29 '21 03:06 galupa

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 29 '21 03:06 sonarqubecloud[bot]

I'm seeing weird padding/margin around the button - can you take a look at it?

image

farhatahmad avatar Sep 18 '21 23:09 farhatahmad

Thank you @farhatahmad for reviewing this, I will check the codes based on your comments

galupa avatar Sep 22 '21 04:09 galupa

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

sonarqubecloud[bot] avatar Sep 27 '21 00:09 sonarqubecloud[bot]

Sorry I have been a bit busy last week, but I have fix the UI issue for this PR, please check again when you have time @farhatahmad

galupa avatar Sep 27 '21 00:09 galupa

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

sonarqubecloud[bot] avatar Dec 23 '21 19:12 sonarqubecloud[bot]