greenlight
greenlight copied to clipboard
Accessibility fix for remove user access
Hi, This PR should enable keyboard user (user that visually impaired) to remove user access from the Share Room Access modal.
By using tabs
key, the user will be able to get to x
remove shared user.
Description
It is just a small changes and all changes are on share room access modal:
- (room.js) Change
x
(remove shared user) from to - (locales) add remove_user so for aria-label, so screen reader can read it.
Testing Steps
To test it:
- Go to shared room access modal
- If there is no user, add a user
- User (you) should be able to remove the user that just added by using only keyboard, using tabs and enter / space key.
Screenshots (if appropriate):
Not much changes, but if you look closely the x
button is select able by keyboard now
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
I'm seeing weird padding/margin around the button - can you take a look at it?
Thank you @farhatahmad for reviewing this, I will check the codes based on your comments
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.6% Duplication
Sorry I have been a bit busy last week, but I have fix the UI issue for this PR, please check again when you have time @farhatahmad
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.4% Duplication