greenlight
greenlight copied to clipboard
Features user settings PR
This PR should enable user settings features. What it does basically create a user specific settings so that user can create personalized setting when they join meetings. It basically use settings on https://docs.bigbluebutton.org/2.2/customize.html#passing-custom-parameters-to-the-client-on-join.
Description
What we change on the code:
- We modify the create room and join room functionality to include the user join setting.
- We create a new entity on database UserSettings that contains the user join setting, we also implement the functionality that enable users to modify the user settings, including with UI template, so there will be a new menu on the user profile.
- We add a new setting on the .env file to setup which user join settings from https://docs.bigbluebutton.org/2.2/customize.html#passing-custom-parameters-to-the-client-on-join that we want to include.
Note: we currently specify this to only enable the skip check audio, skip video preview, auto share webcam and listen only mode. To enable more, just add more user join settings on the .env file and some additional entry on locales also might be needed
Testing Steps
To test this PR:
- migrate the database so that user settings table is created on the database
- update the .env file to enable which user settings to enable, also the default values. example:
JOIN_SETTINGS_FEATURES=userdata-bbb_skip_check_audio,userdata-bbb_skip_video_preview,userdata-bbb_auto_share_webcam,userdata-bbb_listen_only_mode
JOIN_SETTINGS_DEFAULT_VALUES=false,false,false,true
- run Greenlight. Login to greenlight. Go to profile --> settings. change some settings and try to join a room.
Note: we also added some unit tests
Screenshots (if appropriate):
Please let me know if more details are needed
Hi @galupa, thank you for resubmitting this PR with more detailed information. I'll take a look at this PR as part of the next major release
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
3.7% Duplication
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.7% Duplication
Can you rebase and resolve the conflicts please? Then I'll take another stab at reviewing this
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.6% Duplication
Thanks, just rebased this one, please check it again when you have time
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.4% Duplication