greenlight icon indicating copy to clipboard operation
greenlight copied to clipboard

Features user settings PR

Open galupa opened this issue 3 years ago • 7 comments

This PR should enable user settings features. What it does basically create a user specific settings so that user can create personalized setting when they join meetings. It basically use settings on https://docs.bigbluebutton.org/2.2/customize.html#passing-custom-parameters-to-the-client-on-join.

Description

What we change on the code:

  1. We modify the create room and join room functionality to include the user join setting.
  2. We create a new entity on database UserSettings that contains the user join setting, we also implement the functionality that enable users to modify the user settings, including with UI template, so there will be a new menu on the user profile.
  3. We add a new setting on the .env file to setup which user join settings from https://docs.bigbluebutton.org/2.2/customize.html#passing-custom-parameters-to-the-client-on-join that we want to include.

Note: we currently specify this to only enable the skip check audio, skip video preview, auto share webcam and listen only mode. To enable more, just add more user join settings on the .env file and some additional entry on locales also might be needed

Testing Steps

To test this PR:

  1. migrate the database so that user settings table is created on the database
  2. update the .env file to enable which user settings to enable, also the default values. example:
JOIN_SETTINGS_FEATURES=userdata-bbb_skip_check_audio,userdata-bbb_skip_video_preview,userdata-bbb_auto_share_webcam,userdata-bbb_listen_only_mode
JOIN_SETTINGS_DEFAULT_VALUES=false,false,false,true
  1. run Greenlight. Login to greenlight. Go to profile --> settings. change some settings and try to join a room.

Note: we also added some unit tests

Screenshots (if appropriate):

Screenshot from 2021-06-08 10-13-03

Please let me know if more details are needed

galupa avatar Jun 07 '21 22:06 galupa

Hi @galupa, thank you for resubmitting this PR with more detailed information. I'll take a look at this PR as part of the next major release

farhatahmad avatar Jun 09 '21 03:06 farhatahmad

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

sonarqubecloud[bot] avatar Jun 26 '21 17:06 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

sonarqubecloud[bot] avatar Aug 10 '21 23:08 sonarqubecloud[bot]

Can you rebase and resolve the conflicts please? Then I'll take another stab at reviewing this

farhatahmad avatar Sep 18 '21 23:09 farhatahmad

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.6% 0.6% Duplication

sonarqubecloud[bot] avatar Sep 27 '21 21:09 sonarqubecloud[bot]

Thanks, just rebased this one, please check it again when you have time

galupa avatar Sep 27 '21 21:09 galupa

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

sonarqubecloud[bot] avatar Jan 19 '22 22:01 sonarqubecloud[bot]