greenlight icon indicating copy to clipboard operation
greenlight copied to clipboard

Clickable and selectable thumbnails

Open hiroshisuga opened this issue 5 years ago • 1 comments

Description

This is a re-posted PR of #1796, which I close by myself. #1796 is a combination of #1752 and #1767 (both closed already)

In this PR I implemented clickable thumbnails for public viewers and selectable thumbnail dropdown for the room owner. I needed to create a new meta parameter "imagesel" to remember the room owner's choice. If Greenlight does not find this parameter, it automatically select the first 3 thumbnails as currently implemented. So far, the owner can select a thumbnail out of three candidates, for each of three thumbnail windows (i.e. you can only change the order). This is a restriction of BBB which registers only three slides for thumbnails. To lift up this restriction, we need a modification in BBB (I haven't sent a PR for it yet). Moreover, a seemingly bug prevents BBB to create thumbnails from the presentation file uploaded by the user. For fixing this bug, I have already sent PRs (bigbluebutton/bigbluebutton#9570 and bigbluebutton/bigbluebutton#9837) in BBB. With the combination of this PR on BBB, users can select thumbnails from the uploaded presentation.

Again, to select thumbnails from the full list of the uploaded slides, we need another modification in BBB. I will post a PR once all the related PRs are merged.

Testing Steps

  1. start a BBB meeting
  2. record it
  3. the record thumbnails are selectable for the owner
  4. open this room as a viewer
  5. the thumbnails are the ones that have been selected by the owner, and they are clickable as links to the playback, but not selectable, as thumbnail selection is just for the room owner.

Screenshots (if appropriate):

84587565-33a61200-ae5b-11ea-9310-8754239b7360

hiroshisuga avatar Apr 07 '21 02:04 hiroshisuga

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 01 '21 13:10 sonarqubecloud[bot]