bbb-playback icon indicating copy to clipboard operation
bbb-playback copied to clipboard

fix: ios safari infinite loader and time parameter

Open DaniilVdovinov opened this issue 1 year ago • 6 comments

Fix iOS safari infinite loader and time parameter

I noticed that in version 4.+ in mobile safari, simultaneous playback of the screen share and a webcam did not work. In version 5.0.0, this bug was fixed (or I updated ios), but in some cases in safari, when opening the page, the loader remained even after loading all the resources. There was also the bug with the t parameter #80

Docs

I think it's related to safari webkit. Safari does not allow you to play more than one <video> with sound on the page. Here are links to explore: webkit bugs, webkit blog, possible solution

Added

  • autoPlay attribute to screen share and webcam <video>
  • pause() after screen share initialization to prevent immediately screen share playback

DaniilVdovinov avatar May 09 '23 17:05 DaniilVdovinov

Hi @DaniilVdovinov , thanks for your contribution. Have you ever signed BigBlueButton's CLA?

pedrobmarin avatar May 10 '23 00:05 pedrobmarin

Hi @DaniilVdovinov

Thank you for this contribution!

Just to give a bit more info on the CLA @pedrobmarin mentioned -- Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance!

antobinary avatar May 10 '23 02:05 antobinary

@antobinary Hi! I sent CLA

DaniilVdovinov avatar Jun 04 '23 09:06 DaniilVdovinov

Thank you @DaniilVdovinov Your CLA was received and all looks good!

antobinary avatar Jun 06 '23 14:06 antobinary

I'm not sure why we don't set the screenshare video muted. Maybe this could work as a solution as well. I still don't understand why we'd need to pause this media. It should be controled by the synchronizer... @antobinary do you think anyone could check on this?

pedrobmarin avatar Jun 06 '23 16:06 pedrobmarin

Hey guys, I didn't quite get it, the safari you are talking about is the desktop one or the iphone's?

Because, I tested here and found the following issue: https://github.com/bigbluebutton/bbb-playback/issues/247 I searched here in the repo and didn't find any known issue regarding that!

GuiLeme avatar Jul 20 '23 18:07 GuiLeme