bbb-install
bbb-install copied to clipboard
Update bbb-install.sh
Added apt update and install ca-certificates since some cloud providers don't have the latest versions of the respective OS which causes certificate errors during software installation. Not sure if this is the right spot to add the update and install.
I'm not sure if we should try to repair outdated images from each and every provider in the world here in this installation routine. It could be a better idea to just emphasize the need of an apt-get update; apt-get upgrade
before installation. The section about pre-installation checks could be the right place for that.
But let's be pragmatic. I would prefer to use the need_pkg
function because it will be more in the style of the existing code and does some optimization. Further, I would pull the installation of the package a little bit more to the top (somewhere at line 230), because this package is independent from the used distro. As a last step, it's worth to take a look into the function install_docker
where this package will be installed, too.
Looks like @ffdixon picked up the suggestion and implemented it in https://github.com/bigbluebutton/bbb-install/commit/4a62a13775b819db2620ccc25ddfe40871ff47a1 The change is included forward too - see https://github.com/bigbluebutton/bbb-install/blob/master/bbb-install-2.5.sh#L239
Thanks @mrichtsfeld and @michi-80337 !