wordpress-git-content icon indicating copy to clipboard operation
wordpress-git-content copied to clipboard
verified publisher icon bigbite

Returning on first error

Open wvpv opened this issue 7 years ago • 0 comments

Hey, I'm curious why you break out of the entire function with the return when you encounter one file that doesn't exist or if the download of the file fails.

Seems like you'd want to continue iterating.

https://github.com/bigbitecreative/wordpress-git-content/blob/80571aa7ec636053912a37f9425cf9c1e1862c89/app/Controllers/RouteController.php#L45

https://github.com/bigbitecreative/wordpress-git-content/blob/80571aa7ec636053912a37f9425cf9c1e1862c89/app/Controllers/RouteController.php#L50

wvpv avatar Apr 15 '18 23:04 wvpv