benenson icon indicating copy to clipboard operation
benenson copied to clipboard
verified publisher icon bigbite

[BUG] Legal Menu and Social Links are not aligned

Open TheE opened this issue 6 years ago • 2 comments

Describe the bug

The alignment of the footer's legal menu and the social icons is completely of. Additionally, the top border of the footer menu is not properly aligned with the content (the last child is missing the rest of the right margin):

benenson-footer-alignment

This seems to be caused by calling @include flexy-column(10) on the page-footerBottomHalf elements.

This is especially troublesome because it cannot be easily overwritten in a child theme.

To Reproduce Steps to reproduce the behaviour:

  1. Add a menu to the Footer Legal location.
  2. Add some social links in the Customizer.
  3. Scroll to the site's footer.

Expected behaviour The legal menu and the social' icons should be placed on the same hight, i.e. by simply using justify-content: space-between. The border of the footer menu should be properly aligned with the content.

Platform (please complete the following information):

  • OS: macOS
  • Browser: Safari
  • Version: 12.1.1

TheE avatar Jun 29 '19 22:06 TheE

I just realised that the misalignment of the border is an issue with the footer menu: the last child is missing the reset of its right margin.

TheE avatar Jul 01 '19 08:07 TheE

Thanks for the report, @TheE; I'll make sure a fix for this gets into the next release.

jaymcp avatar Jul 03 '19 15:07 jaymcp