[BUG] Master fails to build with gulp errors

[jjsanderson]

Describe the bug While trying to troubleshoot #152 I've tried to build master, which throws gulp errors.

To Reproduce Steps to reproduce the behaviour:

1. clone master
2. per the wiki: yarn install, gulp build --production
3. See error

Expected behaviour Successful build.

Developer console output (if applicable): Error:

const { Math, Object } = primordials;
                         ^

ReferenceError: primordials is not defined

This appears to be a gulp 3 issue with node 12: see this issue). Requiring gulp 4.0.2 in package.json throws a syntax error in gulp/tasks/browsersync.js; attempting to debug that reveals version issues for graceful-fs, and very quickly I'm into stuff that's way beyond my ken.

Platform (please complete the following information):

• OS X 10.14.2
• node 12.3.1
• yarn 1.16.0
• gulp 3.9.1 / 4.0.2

[jjsanderson]

Update: looks like it is the gulp 3 / node 12 issue. If I nvm install 8.16.0 then run the yarn/gulp tasks, build succeeds as expected.

[jaymcp]

@jjsanderson Thanks for the report, it is appreciated. The v1.2.0 milestone should include an upgraded build system, along with many other improvements and additions, which should hopefully allow for working builds on the latest node versions.

[jjsanderson]

Cool, thanks @jonmcp. I realise it's early days for the theme. I'll carry on logging issues if and as I come across them, but if that's not helpful do tell me to shut up!

[jaymcp]

@jjsanderson please do keep logging issues if you see them, it's extremely helpful and greatly appreciated! :)