quantms icon indicating copy to clipboard operation
quantms copied to clipboard

Enable MBR in DIA-NN step

Open daichengxin opened this issue 3 years ago • 4 comments

Description of feature

Now, due to make things as parallelisable as possible, Thus, step 2 consists of analysing each run separately with the in silico library generated in step 1. so we should think about adding MBR in one big node . See details: https://github.com/bigbio/quantms/issues/164

daichengxin avatar Nov 01 '22 02:11 daichengxin

Hi, this is marked as completed, but I don't see the --reanalyse parameter anywhere in the code. What was the strategy to implement MBR for parallelised DiaNN?

calizilla avatar Jul 28 '23 06:07 calizilla

@calliza you are right. Let me re-open the issue.

ypriverol avatar Jul 28 '23 07:07 ypriverol

Is this still considered as an open issue? To my understanding the re-analysis step based on the empirical library actually is an MBR -analysis. Please correct me if I am wrong. So --re-analysis is only required if full analysis (1st and 2nd pass) are being in one step (non-parallelized)

michaelsteidel86 avatar Dec 18 '23 10:12 michaelsteidel86

Is this still considered as an open issue? To my understanding the re-analysis step based on the empirical library actually is an MBR -analysis. Please correct me if I am wrong. So --re-analysis is only required if full analysis (1st and 2nd pass) are being in one step (non-parallelized)

Yes I think you are correct, apologies for causing a re-open, I was new to DIA-NN at the time.

calizilla avatar Jan 12 '24 02:01 calizilla

No worries! Good to clear that up for other users.

jpfeuffer avatar Aug 25 '25 09:08 jpfeuffer