quantms icon indicating copy to clipboard operation
quantms copied to clipboard

Inclusion of the MSFragger search engine and open search feature

Open tillenglert opened this issue 3 years ago • 4 comments

Description of feature

I'm aiming to integrate the MSFragger search engine into the QuantMS workflow. It should be included as an option for the closed search, alongside a completely new open modification search feature. The roadmap and workarounds (licencing of MSFragger) suggested by @ypriverol for the inclusion are as follows:

  1. Require msfragger to be added to the bin folder of the pipeline with no container in the middle.
  2. Execute msfragger search always from the bin like a normal java tool. No container needed
  3. For CI/CD put the msfragger version into a private place (github repo) or other authenticated system, add the keys to the secrets in quantms repo, and pull the msfragger before testing
  4. Put all the other tools needed that are free into conda packages.
  5. Implement the msfragger steps as a new search engine (for closed search)
  6. Implement a pipeline (with no comet or msgf+) for open search based on msfragger
  7. Testing both pipelines and integration into quantms with some data
  8. Run in the existing datasets and see how it goes in both pipelines (multi-closed-search) and (open search) to detect new modifications

tillenglert avatar May 02 '22 14:05 tillenglert

@tillenglert If there are licensing issues at play, you could also consider using Sage instead of MSFragger.

Sage is an open source & MIT-licensed search engine that uses MSFragger's ion indexing approach, runs up to 5x faster on open (and narrow) searches, and supports RT prediction, integrated linear discriminant analysis, PEP calculation, and TMT quantification.

lazear avatar Oct 07 '22 19:10 lazear

@lazear can you give me a contact to call you and talk. We are really interested in integrating Sage in quantms. I have tried to reach you over twitter or scripps but can't find an email.

ypriverol avatar Oct 07 '22 19:10 ypriverol

@ypriverol you can reach me at michael [email protected] (no space)!

lazear avatar Oct 07 '22 20:10 lazear

https://github.com/bigbio/quantms/pull/236

tillenglert avatar Nov 07 '22 14:11 tillenglert

We already have support for SAGE. WE will close this issue.

ypriverol avatar Mar 10 '25 06:03 ypriverol