wheel icon indicating copy to clipboard operation
wheel copied to clipboard

Port to react-router-dom v6

Open yedhink opened this issue 3 years ago • 1 comments
trafficstars

Now by default react-router-dom pulls down v6.

This means, our existing components have a chance to break.

I can hardcode the version to 5.3.0 and things would work. But that doesn't seem like the permanent fix.

Let's actually port to v6.

@edwinbbu _a

Can you please take this up? Thanks.

Refer: https://reactrouter.com/docs/en/v6/faq

yedhink avatar Nov 26 '21 10:11 yedhink

I am not sure if it's the right time to upgrade to v6. Backward compatibility is not yet available (Ref). Another reason is that neetoUI uses react-router-dom as the peer dependency. Hence changes might be required in neetoui. Then the applications using the neetoui latest version has to use react-router-dom v6

Anyway, I will try it out and see how it goes.

edwinbbu avatar Nov 30 '21 18:11 edwinbbu

@yedhink _A Can you please verify whether we have already implemented it or not and close it asap?

cc: @Amaljith-K

sumanranjanpanda avatar May 17 '23 07:05 sumanranjanpanda

This needn't be done in Wheel until neeto adopts V6. We have to also upgrade React 18 for this as far as I know.

yedhink avatar May 17 '23 07:05 yedhink

neeto won't be migrating to react-router-dom v6 Refer: https://github.com/bigbinary/neeto-engineering-web/issues/155#issuecomment-1343959024

Amaljith-K avatar May 17 '23 09:05 Amaljith-K