wls_datasource xaproperties not idempotent

[nanliu]

wls_datasource xaproperties properties is not idempotent because it is not implemented in files/providers/wls_datasource/index.py.erb.

Notice: /Stage[main]/Fusion::Weblogic::Admin/Wls_datasource[ei_app]/xaproperties: defined 'xaproperties' as 'XaSetTransactionTimeout=1,XaRetryIntervalSeconds=60

The bigger issue is puppet native array comparison does not have inclusive v.s. non inclusive comparison which makes the implementation difficult. There is an example for improving puppet type, which should be ported to easy type:

https://github.com/vmware/vmware-vmware_lib/blob/master/lib/puppet/property/vmware_array.rb

This will improve issues such as #168 if we implement our own array in_sync behavior.

[biemond]

added @hajee for easy_type part

[biemond]

the xa part was a pull request and I also noticed this. The index part is on my todo list.

thanks

[hajee]

@nanliu Right now easy_type doesn't add any help for insync? checking. Is your suggestion we add some sort of a helper? Or are you suggesting we override the current implementation with a smarter one?

[nanliu]

@hajee I wasn't sure if things like #168 was a one off, or if you need custom array comparison behavior. If it's not a oneoff, it might be better to implement a standard puppet property in easytype that implement the insync? method. I see there are several places where this repeated:

https://github.com/biemond/biemond-orawls/search?q=insync&type=Code&utf8=%E2%9C%93

[BasLangenberg]

Just FYI, I am struggling with this problem as well and I need it to be solved for our implementation due to compliance ruling. I'll try and fix this and shoot a pull request your way, @biemond

[BasLangenberg]

See #188. It solves the issue for me.