WIP: Status of ANCP refactor

[effigies]

During BrainHack Global 2022, we will be working at https://github.com/bids-standard/pybids-refactor.

[codecov[bot]]

Codecov Report

Base: 86.24% // Head: 83.76% // Decreases project coverage by -2.49% :warning:

Coverage data is based on head (00850df) compared to base (b3351dd). Patch coverage: 12.09% of modified lines in pull request are covered.

:exclamation: Current head 00850df differs from pull request most recent head b94864d. Consider uploading reports for the commit b94864d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage   86.24%   83.76%   -2.49%     
==========================================
  Files          32       33       +1     
  Lines        3904     4028     +124     
  Branches      947      966      +19     
==========================================
+ Hits         3367     3374       +7     
- Misses        346      463     +117     
  Partials      191      191              

Impacted Files	Coverage Δ
bids/layout/layout_v2.py	7.62% <7.62%> (ø)
bids/layout/__init__.py	100.00% <100.00%> (ø)
bids/modeling/statsmodels.py	83.43% <0.00%> (-2.55%)	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[Shotgunosine]

Just curious, how's this going?

[effigies]

In fits and starts. @adelavega says actually not terrible, limited mostly by bandwidth.

We're thinking a bit about a new API that will make layout more a manipulable object than a one-stop shop. It's a pretty sparse draft at the moment, but in case you are interested in commenting: https://hackmd.io/i-o0bbTjRga4Cn2fvx7NGQ

We plan to polish it up and post it for wider comment soon.

[Shotgunosine]

Thanks, glad to know this is still in the works!

On Tue, Mar 7, 2023 at 9:15 AM Chris Markiewicz @.***> wrote:

In fits and starts. @adelavega https://github.com/adelavega says actually not terrible, limited mostly by bandwidth.

We're thinking a bit about a new API that will make layout more a manipulable object than a one-stop shop. It's a pretty sparse draft at the moment, but in case you are interested in commenting: https://hackmd.io/i-o0bbTjRga4Cn2fvx7NGQ

We plan to polish it up and post it for wider comment soon.

— Reply to this email directly, view it on GitHub https://github.com/bids-standard/pybids/pull/926#issuecomment-1458249540, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABILLGG52FCHUMSB6VHGZTLW247IFANCNFSM6AAAAAASUV467I . You are receiving this because you commented.Message ID: @.***>

[effigies]

@adelavega Correct me if I'm wrong, but the plan moving forward would be to integrate bids2table instead?

[adelavega]

Into a separate library, yes

[adelavega]

To add more context; I'm not sure if we can or should rely on ancpbids given it tenous maintenance and somewhat higher complexity.

One advantage of bids2table is the main complexity will be the (to be updated) loading function using BIDS Schema into parquet, and the querying logic should be implemented by other packages. Then we will design a wrapped to be PyBIDS-like around it, which much more pared down API compared to the current one.