pybids icon indicating copy to clipboard operation
pybids copied to clipboard

Support for microscopy samples.tsv

Open Remi-Gau opened this issue 2 years ago • 2 comments

I was wondering if it would be possible to add the samples.tsv file to the get_collections function at the "dataset" level At the moment, the "dataset" level seems to only index metadata from participants.tsv.

For example on micr_SPIM with:

subj_df = layout.get_collections(level='dataset', merge=True).to_df()
subj_df

I get the following from participant.tsv, but samples.tsv metadata is not present: image

Originally posted by @mariehbourget in https://github.com/bids-standard/pybids/pull/840#pullrequestreview-945892337

Remi-Gau avatar Apr 25 '22 07:04 Remi-Gau

Hi @Remi-Gau, I would like to give this a try but I was wondering if it was worth it or if there are plans to do the indexing with the schema instead in the short term? thanks

mariehbourget avatar Jul 07 '22 19:07 mariehbourget

I would say that you should go ahead and that things will be adapted "fairly smoothly" (famous last words) when pybids relies on the schema for indexing.

feel free to ping me for PR review

Remi-Gau avatar Jul 07 '22 21:07 Remi-Gau