bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

PHENOTYPE_SUBJECTS_MISSING issue

Open JonteP opened this issue 3 years ago • 6 comments

Hello,

I've run into what might be an edge case. I have one participant with missing imaging data but questionnaires filled in. This participant is thus present in the phenotype folder and participants.tsv. This raises the error PHENOTYPE_SUBJECTS_MISSING when running the BIDS validator. Maybe there is something that I am missing, but it seems like the validator does not expect this scenario.

JonteP avatar Oct 06 '22 20:10 JonteP

Hi @JonteP, this may be of interest to you:

  • https://github.com/bids-standard/bids-specification/issues/914

sappelhoff avatar Oct 08 '22 10:10 sappelhoff

Is this an issue in the current (schema) validator?

effigies avatar Aug 29 '24 21:08 effigies

Yes. It is also causing errored validation on my old OpenNeuro dataset ds004215 (now ds005752). In our case there are 1,608 subjects with survey (phenotype/) data, but without sub-*/ directory data.

Image

ericearl avatar Jan 22 '25 16:01 ericearl

@ericearl My understanding is that this needs to be resolved in the specification (and schema). https://github.com/bids-standard/bids-specification/issues/914 is where this needs to be finalized.

My reading is that we came to a position that seemed to work, and nobody objected, but a PR was never opened.

With the rule as written at the bottom, I don't think the expression language can express that rule yet, but we can figure that out.

effigies avatar Jan 22 '25 17:01 effigies

@effigies Cool, I will work on a PR to the spec now.

ericearl avatar Jan 22 '25 17:01 ericearl

PR added here: https://github.com/bids-standard/bids-specification/pull/2044.

ericearl avatar Feb 05 '25 15:02 ericearl