bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

Participant data not being returned

Open happy5214 opened this issue 1 year ago • 4 comments

I'm currently trying to add support for HED validation in participants.tsv files, and I'm running into an issue getting the participant data passed to HED. First of all, it seems the participants object doesn't include the full row, but I can't even use that data because I'm just getting null when I try to access it (the main point of this issue). I've tried it on the fmri_ds002790s_hed_aomic hed-examples dataset, which clearly has a participants.tsv, to no avail.

happy5214 avatar Jul 25 '23 19:07 happy5214

cc @rwblair

sappelhoff avatar Jul 31 '23 09:07 sappelhoff

Just a few extra comments:

  1. The dataset above is fmri_ds002790s_hed_aomic.
  2. We noticed that if we removed a line from the participants.tsv file that error 40 wasn't being thrown indicating that a subject was missing an entry in the participants file.

VisLab avatar Jul 31 '23 11:07 VisLab

The assignment in https://github.com/bids-standard/bids-validator/blob/6fc6d152b52266934575442e61f1477ba18f42ec/bids-validator/validators/tsv/validate.js#L40 is not showing up upon returning to fullTest. null is passed as the value of participants into the function, so perhaps the assignment is being ignored? (Is null passed by value?) The assignment in https://github.com/bids-standard/bids-validator/blob/6fc6d152b52266934575442e61f1477ba18f42ec/bids-validator/validators/tsv/validate.js#L45 seems to work, so the code is being executed.

@rwblair

happy5214 avatar Aug 04 '23 16:08 happy5214