bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

phenotype tsv file with multiple rows for same subject

Open Moo-Marc opened this issue 2 years ago • 3 comments

Hello,

As mentioned on Neuro Stars, the validator returns error [Code 51] PHENOTYPE_SUBJECTS_MISSING when a single subject appears multiple times (multiple rows). The error is misleading since the subject is not missing in the database. Furthermore, I don’t think multiple entries for a single subject is forbidden. E.g., a subject may fill a questionnaire on multiple sessions.

In case this question leads to thoughts that it should be forbidden, note that in my particular case (for the OMEGA repository), the repeated measures are mostly from a few participants that came for different studies. This is not a planned repeated measure. Thus it wouldn't make sense to have a second (3rd, etc) table or added columns for the additional entries for example.

Cheers, Marc

Moo-Marc avatar Jun 21 '22 15:06 Moo-Marc

Thanks for the report, I agree that this is a bug.

Furthermore, I don’t think multiple entries for a single subject is forbidden. E.g., a subject may fill a questionnaire on multiple sessions.

I agree that the spec does not forbid such a thing explicitly: source

slightly related and perhaps of interest to you: https://github.com/bids-standard/bids-specification/issues/914

sappelhoff avatar Jul 12 '22 09:07 sappelhoff

I am also seeing this with version 1.9.4. However, I also see this error even with single row per subject for some tsv files. For example, for a phenotype/demographics.tsv file, it throws this error listing as "evidence" 4 out of 447 subjects, even though they have a single row entry like the rest, and despite being included in particpants.tsv and having a sub-XX bds folder.

ins0mniac2 avatar Jun 22 '23 03:06 ins0mniac2

Has there been any progress on this ? The latest validator 1.13 still throws the error.

ins0mniac2 avatar Nov 02 '23 18:11 ins0mniac2