bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

[SCHEMA] physio and stim not included for EEG, MEG, iEEG and PET

Open Remi-Gau opened this issue 3 years ago • 12 comments

physio and stim suffixes are currently included for func and beh.

But they are not included for the following data types:

  • [x] EEG: https://github.com/bids-standard/bids-specification/blob/master/src/schema/datatypes/eeg.yaml
  • [x] iEEG: https://github.com/bids-standard/bids-specification/blob/master/src/schema/datatypes/ieeg.yaml
  • [x] MEG: https://github.com/bids-standard/bids-specification/blob/master/src/schema/datatypes/meg.yaml
  • [x] PET: https://github.com/bids-standard/bids-specification/blob/master/src/schema/datatypes/pet.yaml
  • [x] ASL
  • [x] DWI

Implement validation for validator:

  • [ ] EEG
  • [ ] iEEG
  • [ ] MEG
  • [ ] PET
  • [ ] ASL
  • [ ] DWI
  • [ ] mri anat

I can't think of a reason for why that's the case, should we add those to the schema ?

Remi-Gau avatar Oct 03 '21 10:10 Remi-Gau

pinging @tsalo :wink:

Remi-Gau avatar Oct 03 '21 10:10 Remi-Gau

actually the physio page says this:

For the template directory name, <datatype> can correspond to any data recording modality, for example func, anat, dwi, meg, eeg, ieeg, or beh.

So I suspect that PET should not be included but some other datatypes should be included.

This might make make the templates of some section complicated to read: for example the one for anat.

Remi-Gau avatar Oct 03 '21 11:10 Remi-Gau

On this topic: @mnoergaard @melanieganz

should PET support physio / stim recording ?

Or is it like supporting task for PET? See this comment: https://github.com/bids-standard/bids-specification/pull/804#discussion_r638214073

Remi-Gau avatar Oct 03 '21 11:10 Remi-Gau

It seems like it should. Should also check in about ASL.

effigies avatar Oct 03 '21 12:10 effigies

@HenkMutsaerts @patsycle

Remi-Gau avatar Oct 03 '21 13:10 Remi-Gau

That should be fine,as this doesn't significantly change the ASL specification, as far as i understand now?

We decided however not to support functional ASL yet as this would require all non task ASL (99% of ASL data) to include task-rest. @patsycle was there also another reason?

Physiological simuli are more common in ASL, in the form of an acetazolamide challenge, breath hold, or CO2 challenge. Would this be covered by physio/stim?

HenkMutsaerts avatar Oct 04 '21 04:10 HenkMutsaerts

@HenkMutsaerts @Remi-Gau Indeed, functional ASL might get implemented later on. If I understand correctly, it was now mainly an issue to get it working in the validator. Marco might remember this.

patsycle avatar Oct 04 '21 08:10 patsycle

Physiological simuli are more common in ASL, in the form of an acetazolamide challenge, breath hold, or CO2 challenge. Would this be covered by physio/stim?

yeah this would be one of the most straightforward way of gas concentration and respiration during your acquisition and it does not need to change anything to the part of ASL spec. We just need mention the physion / stim page that ASL supports it.

Remi-Gau avatar Oct 04 '21 11:10 Remi-Gau

@HenkMutsaerts @Remi-Gau Indeed, functional ASL might get implemented later on. If I understand correctly, it was now mainly an issue to get it working in the validator. Marco might remember this.

If you are referring to the fact that physio files in the perf folder should also be also be validated that is correct. This would need to be implemented.

Remi-Gau avatar Oct 04 '21 11:10 Remi-Gau

I suggest implementing this in several PRs split up by datatypes with a counterparts on the validator side.

  • eeg, meg, ieeg
  • dwi
  • asl
  • pet
  • anat (I am struggling to imagine the use case for physio and stim for anat but I may be missing something)

Remi-Gau avatar Oct 04 '21 11:10 Remi-Gau

OK I will wait for the bids-standard/bids-specification#883 to be in before opening PRs on this to avoid potential merge conflicts.

Remi-Gau avatar Oct 05 '21 08:10 Remi-Gau

Will actually transfer this to the validator to remember to implement it.

Remi-Gau avatar Feb 01 '22 18:02 Remi-Gau