bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

false positive 'dead links'

Open Remi-Gau opened this issue 9 months ago • 5 comments

Some dicom tags links are making are link checks fail:

https://dicomlookup.com/dicomtags/(0008,0022) https://dicomlookup.com/dicomtags/(0008,0028) https://dicomlookup.com/dicomtags/(0008,0034) https://dicomlookup.com/dicomtags/(0008,0070) https://dicomlookup.com/dicomtags/(0008,0080) https://dicomlookup.com/dicomtags/(0008,0081) https://dicomlookup.com/dicomtags/(0008,0100) https://dicomlookup.com/dicomtags/(0008,0102) https://dicomlookup.com/dicomtags/(0008,0103) https://dicomlookup.com/dicomtags/(0008,0104) https://dicomlookup.com/dicomtags/(0008,1010) https://dicomlookup.com/dicomtags/(0008,1040) https://dicomlookup.com/dicomtags/(0008,1090) https://dicomlookup.com/dicomtags/(0012,0063) https://dicomlookup.com/dicomtags/(0012,0064) https://dicomlookup.com/dicomtags/(0018,0015) https://dicomlookup.com/dicomtags/(0018,0020) https://dicomlookup.com/dicomtags/(0018,0021) https://dicomlookup.com/dicomtags/(0018,0022) https://dicomlookup.com/dicomtags/(0018,0023) https://dicomlookup.com/dicomtags/(0018,0024) https://dicomlookup.com/dicomtags/(0018,0080) https://dicomlookup.com/dicomtags/(0018,0081) https://dicomlookup.com/dicomtags/(0018,0082) https://dicomlookup.com/dicomtags/(0018,0087) https://dicomlookup.com/dicomtags/(0018,1000) https://dicomlookup.com/dicomtags/(0018,101A) https://dicomlookup.com/dicomtags/(0018,1020) https://dicomlookup.com/dicomtags/(0018,1048) https://dicomlookup.com/dicomtags/(0018,1072) https://dicomlookup.com/dicomtags/(0018,1073) https://dicomlookup.com/dicomtags/(0018,1074) https://dicomlookup.com/dicomtags/(0018,1077) https://dicomlookup.com/dicomtags/(0018,1210) https://dicomlookup.com/dicomtags/(0018,1242) https://dicomlookup.com/dicomtags/(0018,1250) https://dicomlookup.com/dicomtags/(0018,1314) https://dicomlookup.com/dicomtags/(0018,9020) https://dicomlookup.com/dicomtags/(0018,9036) https://dicomlookup.com/dicomtags/(0018,9049) https://dicomlookup.com/dicomtags/(0018,9052) https://dicomlookup.com/dicomtags/(0018,9053) https://dicomlookup.com/dicomtags/(0018,9069) https://dicomlookup.com/dicomtags/(0018,9073) https://dicomlookup.com/dicomtags/(0018,9078) https://dicomlookup.com/dicomtags/(0018,9081) https://dicomlookup.com/dicomtags/(0018,9100) https://dicomlookup.com/dicomtags/(0018,9155) https://dicomlookup.com/dicomtags/(0018,9254) https://dicomlookup.com/dicomtags/(0018,9255) https://dicomlookup.com/dicomtags/(0018,9257) https://dicomlookup.com/dicomtags/(0018,9258) https://dicomlookup.com/dicomtags/(0018,9259) https://dicomlookup.com/dicomtags/(0018,925A) https://dicomlookup.com/dicomtags/(0018,925C) https://dicomlookup.com/dicomtags/(0018,925E) https://dicomlookup.com/dicomtags/(0018,925F) https://dicomlookup.com/dicomtags/(0019,1028) https://dicomlookup.com/dicomtags/(0020,0110) https://dicomlookup.com/dicomtags/(0054,1001) https://dicomlookup.com/dicomtags/(0054,1101) https://dicomlookup.com/dicomtags/(0054,1103) https://dicomlookup.com/dicomtags/(0054,1321) https://dicomlookup.com/dicomtags/(0054,1322) https://dicomlookup.com/dicomtags/(0054,1323)

See for example: https://app.circleci.com/pipelines/github/bids-standard/bids-specification/8419/workflows/09a7af2e-9c35-472c-af23-1d1919d95e3a/jobs/24833

error example

URL        `https://dicomlookup.com/dicomtags/(0008,0070)'
Name       `DICOM Tag 0008, 0070'
Parent URL file:///home/circleci/project/site/modality-specific-files/magnetic-resonance-imaging-data.html, line 2458, col 83
Real URL   https://dicomlookup.com/dicomtags/(0008,0070)
Check time 0.077 seconds
Result     Error: SSLError: HTTPSConnectionPool(host='dicomlookup.com', port=443): Max retries exceeded with url: /dicomtags/(0008,0070) (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate ...

Remi-Gau avatar Feb 26 '25 13:02 Remi-Gau

I have not checked them all but some seem to indeed to lead 'nowhere':

https://dicomlookup.com/dicomtags/(0018,9259)

Remi-Gau avatar Feb 26 '25 13:02 Remi-Gau

The general problem is an expired SSL certificate. I am surprised that some are undefined, but I guess we will need to do some reconstruction to figure out where these tags came from and what they should link to.

effigies avatar Feb 26 '25 16:02 effigies

those that do not seem to match any known dicom tags

https://dicomlookup.com/dicomtags/(0019,1028) https://dicomlookup.com/dicomtags/(0018,925F) https://dicomlookup.com/dicomtags/(0018,925E) https://dicomlookup.com/dicomtags/(0018,925C) https://dicomlookup.com/dicomtags/(0018,925A) https://dicomlookup.com/dicomtags/(0018,9259) https://dicomlookup.com/dicomtags/(0018,9258) https://dicomlookup.com/dicomtags/(0018,9257) https://dicomlookup.com/dicomtags/(0018,9255) https://dicomlookup.com/dicomtags/(0018,9254) https://dicomlookup.com/dicomtags/(0012,0064) https://dicomlookup.com/dicomtags/(0012,0063) https://dicomlookup.com/dicomtags/(0008,0104) https://dicomlookup.com/dicomtags/(0008,0100) https://dicomlookup.com/dicomtags/(0008,0028)

Remi-Gau avatar Feb 26 '25 17:02 Remi-Gau

Just noted that too, for me it is just completely gone "dicomlookup.com took too long to respond.". Pinged @dclunie via email about the best alternative.

yarikoptic avatar Mar 03 '25 14:03 yarikoptic

Started looking up a handful:

Code Field Note
0008,0028 PharmaceuticalDoseAmount Should be 0018,0028
0008,0100 CodeValue Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0008,0104 CodeMeaning Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0012,0063 DeidentificationMethod Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0012,0064 DeidentificationMethodCodeSequence Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,9254 ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,9255 ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,9257 ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,9258 ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,9259 ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,925A ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,925C ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,925E ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/
0018,925F ASL* Present in https://www.dicomlibrary.com/dicom/dicom-tags/

effigies avatar Mar 03 '25 14:03 effigies