bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

Published 20 hours ago • verified publisher icon bids-standard

[ENH] Schema changes related to BEP032

Open ree-gupta opened this issue 1 year ago • 3 comments

  • BIDS BEP032 Proposal
  • Contributes to #1705
  • Related issue about age #1634
  • [ ] Clarify if columns can have arrays as value, if not, how do we handle the surgery_date
  • [x] Add columns for _probes.tsv
  • [x] Add tabular_data rules for _probes.tsv
  • [x] Add columns for _electrodes.tsv
  • [x] Add tabular_data rules for _electrodes.tsv
  • [x] Add columns for _channels.tsv
  • [x] Add tabular_data rules for _channels.tsv
  • [x] Add columns for _scans.tsv --> not required as already inherited from main BIDS
  • [x] Add tabular_data rules for _scans.tsv --> not required as already inherited from main BIDS
  • [x] Add columns for _events.tsv
  • [x] Add tabular_data rules for _events.tsv
  • [x] Add sidecars rule for _coordsystem.json
  • [x] Add sidecars rule for _ephys.json (except probe information as decision pending)
  • [x] Fix language conventions, such as ~~for e.g.~~ -> for example,
  • [ ] Discuss and clear TODOs commented out in the schema
  • [ ] Add file naming and other modality-specific rules
  • [ ] Fix schema validation errors

@bids-standard/bep032

ree-gupta avatar May 17 '24 10:05 ree-gupta

@ree-gupta Thanks again for working on this! Could you please "enable" pre-commit for you locally -- pre-commit install so then it would check/address problems before you even make/push a commit?

yarikoptic avatar Jun 05 '24 17:06 yarikoptic

@ree-gupta Thanks again for working on this! Could you please "enable" pre-commit for you locally -- pre-commit install so then it would check/address problems before you even make/push a commit?

Sure thing! Thank you for the suggestion.

ree-gupta avatar Jun 18 '24 07:06 ree-gupta

Took me awhile, even sent complimentary #1963 to see the obvious gotcha! ;) pushed the fix -- hopefully gets green now @ree-gupta ! Thanks again for working on this!!!

edit: CI is green where we care.

yarikoptic avatar Oct 18 '24 00:10 yarikoptic

Took me awhile, even sent complimentary #1963 to see the obvious gotcha! ;) pushed the fix -- hopefully gets green now @ree-gupta ! Thanks again for working on this!!!

edit: CI is green where we care.

Thank you for spotting and fixing this @yarikoptic! 🙏🏽 the schema validation check passes now.

ree-gupta avatar Nov 15 '24 14:11 ree-gupta