bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

[ENH] apply derivative definition to qMRI

Open Remi-Gau opened this issue 1 year ago • 2 comments

  • closes #1812

  • update qMRI sections that mention qmaps: https://bids-specification--1813.org.readthedocs.build/en/1813/appendices/qmri.html#outputs-are-quantitative-maps

Remi-Gau avatar May 06 '24 12:05 Remi-Gau

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.10%. Comparing base (7b0f76d) to head (39c6cfc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1813   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files          16       16           
  Lines        1396     1396           
=======================================
  Hits         1230     1230           
  Misses        166      166           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 12:05 codecov[bot]

Will create a companion PR to modify a couple of bids example to make that the validator has got something to sink its teeth into.

Remi-Gau avatar May 07 '24 07:05 Remi-Gau

@agahkarakuzu can you maybe cross-check what I did here?

Remi-Gau avatar Aug 29 '24 15:08 Remi-Gau

@Remi-Gau the changes you introduced looks good to me! This was initially what we wanted to do, but at that time it was not really clear. Thank you!

agahkarakuzu avatar Aug 29 '24 17:08 agahkarakuzu