bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

[ENH] Allow to keep heading of admonition in PDF

Open Remi-Gau opened this issue 1 year ago • 4 comments

  • closes #1752

Remi-Gau avatar Apr 11 '24 12:04 Remi-Gau

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (591eebb) to head (c9971d9). Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1768   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 11 '24 12:04 codecov[bot]

Should only affect the PDF.

image

image

Remi-Gau avatar Apr 11 '24 12:04 Remi-Gau

I don't love how this looks, as the connection between the header and content isn't clear. Perhaps we could look into using existing pandoc tooling instead of hacking our own thing?

  • https://github.com/Wandmalfarbe/pandoc-latex-template/issues/346
  • https://github.com/jgm/pandoc/discussions/9394
  • https://stackoverflow.com/questions/74289155/formatting-docbook-admonitions-with-pandoc

effigies avatar Apr 11 '24 15:04 effigies

thanks for the pointers

will try if a simple div may do the work in better way

  • https://github.com/jgm/pandoc/discussions/9394#discussioncomment-8352439
  • https://pandoc.org/chunkedhtml-demo/8.18-divs-and-spans.html

Remi-Gau avatar Apr 11 '24 15:04 Remi-Gau