bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

SCHEMA: Define JSON documents in schema

Open effigies opened this issue 3 years ago • 1 comments

Follow up to #1233. This makes genetic_info.json and dataset_description.json objects in objects.documents instead of objects.metadata, which seems more appropriate.

One sticking point is how to indicate conditional requirement levels in an object, rather than a rule.

effigies avatar Nov 10 '22 21:11 effigies

Codecov Report

Base: 88.65% // Head: 88.33% // Decreases project coverage by -0.31% :warning:

Coverage data is based on head (af09b93) compared to base (e70278c). Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   88.65%   88.33%   -0.32%     
==========================================
  Files          11       11              
  Lines        1084     1089       +5     
==========================================
+ Hits          961      962       +1     
- Misses        123      127       +4     
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/render/tables.py 85.42% <20.00%> (-1.69%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Nov 11 '22 15:11 codecov[bot]