[ENH] add task metadata to PET

[Remi-Gau]

closes #1188

To view the final render:

https://bids-specification--1196.org.readthedocs.build/en/1196/04-modality-specific-files/09-positron-emission-tomography.html#task

[Remi-Gau]

Better but it seems that dumping extra metadata in the json did not trigger any failure in the bids examples repo, so let's open an issue to remember to do it but hell should not break loose if we don't do it right away.

https://github.com/bids-standard/bids-examples/pull/330

[sappelhoff]

Better but it seems that dumping extra metadata in the json did not trigger any failure in the bids examples repo, so let's open an issue to remember to do it but hell should not break loose if we don't do it right away.

That is because AdditionalProperties is not declared in the JSON schema ... and if not declared, it defaults to "true" -- so you may add any metadata right now.

• http://json-schema.org/understanding-json-schema/reference/object.html#additional-properties
• https://github.com/bids-standard/bids-validator/blob/d96d6ff2ee30a6620d91d1d881fdc6e5db9023e9/bids-validator/validators/json/schemas/pet.json#L1

Still, the metadata should be added to the json schema in the validator

[codecov[bot]]

Codecov Report

Merging #1196 (fd39d09) into master (db4b0f5) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files           6        6           
  Lines        1020     1020           
=======================================
  Hits          900      900           
  Misses        120      120           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.