bids-specification icon indicating copy to clipboard operation
bids-specification copied to clipboard

[SCHEMA] Order entities and add workflow to check entity order

Open Remi-Gau opened this issue 3 years ago • 3 comments

closes #1189 closes #1071

unrelated

  • fixes some typos and use of abbreviations in schema

Remi-Gau avatar Aug 09 '22 14:08 Remi-Gau

I think this is a good thing to do, though I don't know if it needs a separate Action. Perhaps a more general one meant to validate schema files would be good. I proposed adding tests for validating the schema in #1037, and I think this fits within that overall goal.

tsalo avatar Aug 11 '22 19:08 tsalo

Should we merge both and then into a different PR refactor the code and convert this action into one that runs all schema tests ?

Remi-Gau avatar Aug 12 '22 07:08 Remi-Gau

waiting for another positive review of #1058 and then we will merge both.

@sappelhoff

I can take care of reorganizing the code after that.

Remi-Gau avatar Aug 12 '22 15:08 Remi-Gau

@Remi-Gau I just approved, please go ahead :-)

sappelhoff avatar Aug 15 '22 09:08 sappelhoff