bids-examples icon indicating copy to clipboard operation
bids-examples copied to clipboard

[ENH] BEP020 examples

Open julia-pfarr opened this issue 3 months ago • 8 comments

Adds example data to complement https://github.com/bids-standard/bids-specification/pull/1128.

Modifications made from #478

@mszinte @oesteban @Remi-Gau

closes mszinte/bids-specification#3

julia-pfarr avatar Sep 12 '25 20:09 julia-pfarr

@effigies @rwblair let me know when the _physioevents.tsv.gz validation isn't failing anymore, then I convert from draft to open

julia-pfarr avatar Sep 12 '25 21:09 julia-pfarr

@julia-pfarr The main thing missing is ScreenOrigin, in both examples:

	[ERROR] INCOMPLETE_STIMULUS_PRESENTATION `StimulusPresentation` metadata for the events file associated with {path}
({associations.events.path}) must have `ScreenDistance`, `ScreenOrigin`,
`ScreenResolution` and `ScreenSize` fields.

		/sub-01/beh/sub-01_task-FreeView_run-01_recording-eye2_physio.tsv.gz
		/sub-01/beh/sub-01_task-FreeView_run-01_recording-eye1_physio.tsv.gz

		2 more files with the same issue

	Please visit https://neurostars.org/search?q=INCOMPLETE_STIMULUS_PRESENTATION for existing conversations about this issue.


          Summary:                         Available Tasks:        Available Modalities:
          21 Files, 7.69 kB                FreeView                beh                  
          1 - Subjects 1 - Sessions 

effigies avatar Sep 15 '25 15:09 effigies

Hi all, I've noticed some updates to the proposed BEP 020 spec https://github.com/bids-standard/bids-specification/pull/1128 .

Do you need me to update the EEG-Eyetracking Example dataset (originally shared here ) in order to match the updated spec?

scott-huberty avatar Sep 15 '25 15:09 scott-huberty

Hi all, I've noticed some updates to the proposed BEP 020 spec bids-standard/bids-specification#1128 .

Do you need me to update the EEG-Eyetracking Example dataset (originally shared here ) in order to match the updated spec?

Hi @scott-huberty, thanks for reminding me that there was this issue and that you wanted to share a BIDS-example as well. Unfortunately, when I click on the link to your dataset or when I search for the dataset number on OpenNeuro, I get an error that I do not have access? Do you know what this is about?

Once I can access the dataset, I can visually inspect it and check with the validator if it needs any updates!

julia-pfarr avatar Sep 15 '25 16:09 julia-pfarr

	[ERROR] MISSING_FOREIGN_COLUMN The `physioevents.tsv.gz` file declared a `ForeignIndexColumn` of {sidecar.ForeignIndexColumn}, but no such column was found in {associations.physio.path}.

		/sub-01/beh/sub-01_task-FreeView_run-02_recording-eye1_physioevents.tsv.gz
		/sub-01/beh/sub-01_task-FreeView_run-01_recording-eye2_physioevents.tsv.gz

		2 more files with the same issue

@effigies is it because it's empty?

julia-pfarr avatar Sep 16 '25 01:09 julia-pfarr

Bug in the schema for loading physio association. Should be fixed now. Triggered a rerun.

effigies avatar Sep 16 '25 21:09 effigies

Hi @scott-huberty, thanks for reminding me that there was this issue and that you wanted to share a BIDS-example as well. Unfortunately, when I click on the link to your dataset or when I search for the dataset number on OpenNeuro, I get an error that I do not have access? Do you know what this is about?

Once I can access the dataset, I can visually inspect it and check with the validator if it needs any updates!

Apologies, the dataset was not published, now it is: https://openneuro.org/datasets/ds005872

I'm sure that I will have to update some fields now that the spec has changed.

scott-huberty avatar Sep 24 '25 18:09 scott-huberty

~~We made OnsetSource (previously ForeignIndexColumn) required in the spec text, but not the schema. I updated that in the schema, and I expect that to fail some of the examples now. I restarted one of the validations to verify.~~

Nevermind, it looks like it's always set in the current examples.

effigies avatar Sep 25 '25 15:09 effigies