bids-examples icon indicating copy to clipboard operation
bids-examples copied to clipboard

[MAINT] check format 'IntendedFor' fields in json files

Open Remi-Gau opened this issue 2 years ago • 6 comments

Preferably this should be the non deprecated format: https://bids-specification.readthedocs.io/en/latest/glossary.html#objects.metadata.IntendedFor

So adding a script to check that in CI.

  • closes #407

Remi-Gau avatar Sep 02 '23 17:09 Remi-Gau

It would be good to implement bids-uris in some tooling before we start converting examples or even warning.

effigies avatar Sep 02 '23 18:09 effigies

It would be good to implement bids-uris in some tooling before we start converting examples or even warning.

you mean like pybids resolving them for example?

In any case fine with me.

I will wrap up this PR and we can leave it hanging until we feel like using it (or not): this was not a lot of work anyway.

Remi-Gau avatar Sep 02 '23 18:09 Remi-Gau

ok added a script to maybe help us convert those URI in batches but the diff gets huge because it may alter the formatting of entire json files at times... so may need improvement...

Remi-Gau avatar Sep 02 '23 19:09 Remi-Gau

apparently this shows that the new format of URI is not supported for mircroscopy by the current version of the validator: should I open an issue on the validator at least for book keeping?

Remi-Gau avatar Sep 02 '23 19:09 Remi-Gau

  • see https://github.com/bids-standard/pybids/issues/950
  • see https://github.com/bids-standard/bids-matlab/issues/624

Remi-Gau avatar Sep 05 '23 13:09 Remi-Gau

apparently this shows that the new format of URI is not supported for mircroscopy by the current version of the validator: should I open an issue on the validator at least for book keeping?

yes please, we should support BIDS URIs in all our validators, even the legacy one

It would be good to implement bids-uris in some tooling before we start converting examples or even warning.

agreed

sappelhoff avatar Oct 27 '23 08:10 sappelhoff