bibletime icon indicating copy to clipboard operation
bibletime copied to clipboard

Published 20 hours ago • verified publisher icon bibletime

New entries for the missing languages - refactor of LAfricain's PR

Open quantumchaos451 opened this issue 2 years ago • 5 comments

Re-factored the pull request from LAfricain (bibletime#237).

Please Note: This is not my work - it's just a re-factor of the work LAfricain has done in the mentioned pull request but taking into account the changes in master.

quantumchaos451 avatar Oct 02 '21 04:10 quantumchaos451

I wonder whether it were possible to automatically generate these language structures from some official ISO 639 tables.

jaakristioja avatar Oct 05 '21 15:10 jaakristioja

To be honest, I'm not sure what our acceptance criteria for this PR should be. I feel that I'm not sufficiently familiar with the abbreviations used by Sword modules (including historic modules people might still use on their systems), and with all the ISO-639 / BCP 47 peculiarities. 😟

jaakristioja avatar Oct 05 '21 15:10 jaakristioja

Maybe the best way forward would be to skip those translations alltogether, and use iso-codes (LGPL2.1+) for both data and translations.

jaakristioja avatar Oct 05 '21 19:10 jaakristioja

I can have a look at https://salsa.debian.org/iso-codes-team/iso-codes and see what would be involved in linking it in if you like. It would probably make more sense to use that, though there may be some cases where older codes are used and are not in there, but they could be handled on a case-by-case basis.

quantumchaos451 avatar Oct 07 '21 04:10 quantumchaos451

I can have a look at https://salsa.debian.org/iso-codes-team/iso-codes and see what would be involved in linking it in if you like. It would probably make more sense to use that, though there may be some cases where older codes are used and are not in there, but they could be handled on a case-by-case basis.

I'm quite certain that using the codes and translations provided by the iso-codes team would be the best for BibleTime, but switching to use iso-codes is also not a simple task. Either way, I don't think this should be part of this PR, so I filed #347 for switching to iso-codes. You're welcome to work on that, if you like. If you do, please let us know so we won't duplicate the work.

That said, I think it might still make sense at this point to finish and merge this pull request, lest we also fail to have #347 ready for BibleTime 3.1 (probably coming in 2022 Q3 or later).

jaakristioja avatar Oct 07 '21 05:10 jaakristioja