tubeup icon indicating copy to clipboard operation
tubeup copied to clipboard

Relocate "source" and "uploader" from item description to item attributes

Open brandongalbraith opened this issue 2 years ago • 1 comments

To address https://github.com/bibanon/tubeup/issues/241 request.

brandongalbraith avatar Oct 04 '22 01:10 brandongalbraith

  • [x] Fix up tests, then ready to ship.

brandongalbraith avatar Oct 04 '22 01:10 brandongalbraith

Were unit tests breaking because the video used for tests changed it's description?

vxbinaca avatar Dec 04 '22 17:12 vxbinaca

Unit tests tested for that output we've removed from the description. Had to update the tests to reflect the change to description output.

brandongalbraith avatar Dec 04 '22 17:12 brandongalbraith

Does the unit tests require the item on IA to be writable by the scripts IA login?

If not, consider using the first video uploaded to Youtube: "A Day At The Zoo".

Note: I own this item.

vxbinaca avatar Dec 05 '22 02:12 vxbinaca

Unit tests don't attempt to write to IA, so the item doesn't need to be writable.

brandongalbraith avatar Dec 06 '22 01:12 brandongalbraith

Unit tests don't attempt to write to IA, so the item doesn't need to be writable.

Try this video instead as a unit test example. It has no description and will likely never ever change. Yes, this is the first thing ever uploaded publicly to the site.

vxbinaca avatar Dec 07 '22 14:12 vxbinaca

Tested, LGTM, merging it up. Revert if any unexpected regressions occur tests don't pick up.

brandongalbraith avatar Dec 27 '22 02:12 brandongalbraith

I'll cut a new version on or before the 1st. Thanks, Brandon.

vxbinaca avatar Dec 27 '22 16:12 vxbinaca

No worries Paul, happy holidays!

brandongalbraith avatar Dec 27 '22 21:12 brandongalbraith