glightbox icon indicating copy to clipboard operation
glightbox copied to clipboard

Published 20 hours ago • verified publisher icon biati-digital

YouTube Shorts

Open leenasn opened this issue 2 years ago • 4 comments

I find that the videos don't play when YouTube Shorts URL is provided. Can someone guide me to fix it?

Thanks, Leena

leenasn avatar Dec 19 '22 12:12 leenasn

Hmmm, that is strange, can you post an example of the url you're using? There is a chance that plyr.js, and subsequently GLightbox, doesn't support that format yet.

gingerchew avatar Dec 19 '22 22:12 gingerchew

Here is a sample URL: https://www.youtube.com/shorts/Rj2JgmXzLxQ

Sorry, forgot to add it earlier.

leenasn avatar Dec 20 '22 04:12 leenasn

Yup its like I thought, currently the regex that looks for the provider is this https://github.com/biati-digital/glightbox/blob/29e365d4148c72ac08da752a5d0ebbe595f7046f/src/js/slides/video.js#L38-L43

If someone wants to add to the regex the necessary regex pieces, I'm more than happy to review the PR :)

gingerchew avatar Dec 24 '22 17:12 gingerchew

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 15 '23 00:07 stale[bot]