glightbox icon indicating copy to clipboard operation
glightbox copied to clipboard

Drafting updates to docs

Open gingerchew opened this issue 3 years ago • 5 comments

gingerchew avatar May 16 '21 19:05 gingerchew

First draft can be found at README_DRAFT.md.

Still needs work as I want to add more examples and maybe include more from the table side of the documentation. Still picking apart what NEEDS to be visible from the get go, and what can be added to a wiki page.

gingerchew avatar May 16 '21 19:05 gingerchew

Looks great 👍 didn't know about svg foreignObject 🤯

About the example "Create multiple galleries from a single lightbox" i think it could be a little confusing for people because that example also shows how to open the lightbox when clicking a button. Maybe we can keep those examples separated just to make sure people do not think that the button is required when creating multiple galleries from a single lightbox when they only need to add the data-gallery attribute, what do you think?

biati-digital avatar May 20 '21 06:05 biati-digital

It is incredible what you can do with svg, haha.

The only downside is that it depends on the raw file link that GitHub creates, which can take 15+ minutes to update sometimes 😬

I agree with the data-gallery example, how about changing it into:

Create a gallery

And moving the button to a new section with titles like:

Open a lightbox with a button

Open a gallery programmatically

Programmatically might be the wrong word.

Following that could be a link to a wiki-page or a CodePen collection or something.

gingerchew avatar May 20 '21 15:05 gingerchew

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Nov 16 '21 19:11 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 25 '22 05:07 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jan 21 '23 12:01 stale[bot]