RxInfer.jl icon indicating copy to clipboard operation
RxInfer.jl copied to clipboard

Free energy is not computed for non-terminated graphs.

Open albertpod opened this issue 1 year ago • 7 comments

We have added predictvars feature for the inference function. Due to some theoretical concerns, the computation of the free energy when missings are present was left aside.

Now, if one wants to compute free energy on non terminated graph, he'll get

The Bethe Free Energy computation is not compatible with the prediction functionality. Set `free_energy = false` to suppress this error.

@ismailsenoz has some good insights on this one in relation to expected free energy. IMHO, we should pick it up.

albertpod avatar Nov 06 '23 10:11 albertpod

@ismailsenoz, perhaps we just want to establish theoretical grounding. The implementation will be for another milestone.

albertpod avatar Nov 14 '23 11:11 albertpod

@ismailsenoz This task has been added to the milestone for tracking and prioritization.

bvdmitri avatar Nov 14 '23 12:11 bvdmitri

We discussed with @albertpod that the heuristic of omitting entropies from the computation seems justified from theoretical grounds. Perhaps, we can discuss if further need be.

ismailsenoz avatar Nov 21 '23 09:11 ismailsenoz

There's still a small realization bottleneck. Let's discuss this onsite. Anyway, I would first address #180, and then we can code this one up.

@bvdmitri WDYT?

albertpod avatar Nov 23 '23 15:11 albertpod

I'm up for the discussion. However, I think #180 is orthogonal to this one and we can start those simultaneously (not necessarily you of course)

bvdmitri avatar Nov 24 '23 08:11 bvdmitri

@albertpod @bvdmitri @ismailsenoz what is the status of this?

wouterwln avatar Mar 15 '24 13:03 wouterwln

I'm not the right person to poke about theoretical grounds of this, but again I'm open for discussions

bvdmitri avatar Mar 15 '24 16:03 bvdmitri