Ben Hollis comments

Results 477 comments of


                                            Ben Hollis

Add the ability to disable artifact mods/effects to loadouts

I'm not sure I entirely follow the idea. Why do you need to redo builds every season? How would this toggle help you avoid doing that?

Add the ability to disable artifact mods/effects to loadouts

I'm not sure but I think the new feature to show loadout issues may help here?

LO: Clearer vendor item icon

Maybe show the actual vendor's icon?

Records Tab certain exotic weapons missing unless already acquired

This was a decision from talking with the Bungie.net folks back in the day. The idea was that some records would be hidden because they were no longer obtainable, and...

Experiment with "stat distance"

Cosine similarity does both hit the intention of the feature better, and is easier to display as a "similarity percentage" (even though it's not really a percentage). With a carefully...

Indicate capped materials on the material counts sheet

Given we don't want to encourage postmaster hoarding I'd say 240?

Include +1 resilience from Solstice Vest (Rekindled) ornament in armor stats

I'm not sure what I'm looking at here. Does the ornament somehow give +1 Resilience?

Include +1 resilience from Solstice Vest (Rekindled) ornament in armor stats

Sounds like a bug on Bungie's side, ornaments really shouldn't grant stats. But besides that, I'd expect that DIM treats it like any other plug and automatically includes its stats...

Notify other tabs of updated data

Alternately we could move a bunch of functionality into a SharedWorker, but that feels like overkill?

Adds support for skin variants

You might want to look at `Regexp.union` as well. If there's any way I could help with merging in this and #4 so we can recognize new emoji, I'd be...