PharmacoGx icon indicating copy to clipboard operation
PharmacoGx copied to clipboard

units must be enforced and/or documented

Open bhaibeka opened this issue 3 years ago • 1 comments

We must properly annotate all units in the PSet.

Is it a requirement that all viability measurements be in percentage and all concentrations in uM?

What happens if the user does not respect this? The plot legends will be all wrong and probably other things. How can we enforce it or make it a parameter/slot in the object?

bhaibeka avatar Apr 01 '21 18:04 bhaibeka

@bhaibeka We have a sanitizeInput function that Mark and I worked on which gives informative errors when things seem wrong. For example, if you set you parameters to computeAUC with viability_as_pct = TRUE but pass in decimals, it notices that there are no values larger than 5 and gives an informative warning.

We can try to enforce certain conventions within PSets, but its hard because some measurements are very bad. Gray has points around 5000% viability (50 as a decimal), for example.

p-smirnov avatar Apr 02 '21 02:04 p-smirnov