Bartłomiej Hirsz
Bartłomiej Hirsz
Looks good now! I will leave few comments regarding lower/upper case, it's not strictly connected to your changed but my though in general for this rule
The whole design of the checker could be improved - and we could scan any Run Keyword and call `check_keyword_naming` on it - > enabling other checks to scan keywords...
> I think it should be used so that test.robot defines Resource called test.resource, not resource.robot. Yeah I agree, I actually copy pasted wrong line from the output. We have...
No worries, it's good to have 'second pair of eyes' on stuff ;) It's indeed parsing error - we're using Robot Framework parsing engine under hood and it does report...
But that's need to be further analysed based on https://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#evaluating-expressions (if it's feasible and when replacing Evaluate is possible and when not).
Yes, there is this weird trick done after running the tests: ``` if self.from_cli: sys.exit(self.reports["return_status"].return_status) else: return self.reports["json_report"].issues ``` Which could lead to unwanted behaviour (for example user configure the...
I took a look into those parts of the code and there is a bit of a mess here :p Hovewer I cannot simply change what's returned from this method....
Detected and fixed by this robotidy transformer (for reference): https://github.com/MarketSquare/robotframework-tidy/blob/main/robotidy/transformers/RemoveEmptySettings.py
I have an idea how it could be implemented - I will try it. The basic design for now: introduce new class ``SeverityThreshold`` which can be added to Rule definition....