Bryan Hilbert
Bryan Hilbert
Initial test on the test server looks good!
Initial test on the test server looks good!
@mfixstsci I think this is ready for review. I ran it twice on the dev server and it completed and the plots look ok. There are definitely a few minor...
@mfixstsci I think all comments have been addressed. Looks like a couple tests are failing though.
I tested this on the test server yesterday, running it twice back to back. The results look good. Tasks left: - [x] Remove lines used for testing (i.e. open up...
@mfixstsci based on @york-stsci 's response in slack, I think this is ready to be merged. I'm not sure how deeply you want to review it. Bourque reviewed it quite...
> > @mfixstsci based on @york-stsci 's response in slack, I think this is ready to be merged. I'm not sure how deeply you want to review it. Bourque reviewed...
@mfixstsci I've taken care of most of the PEP8 issues. The few that are left are: 1) multiline import statements. I feel like indenting the second line to match the...
@mfixstsci I don't think we want to change "== True" to "is True" in 3). That line is going into a database query. See the note above that line [here](https://github.com/spacetelescope/jwql/blob/1436932cbd92896fd5dbb08e812b7e7529e70432/jwql/instrument_monitors/common_monitors/cosmic_ray_monitor.py#L400)....
@mfixstsci I think I've finally addressed everything. I noticed #1034 while checking the log this morning, but I think that is either a pipeline issue or an issue with the...