json-logic-ruby icon indicating copy to clipboard operation
json-logic-ruby copied to clipboard

Javascript only

Open ghost opened this issue 4 years ago • 6 comments

This so-called 'gem' only works as advertised with Javascript.

Don't waste your time...

-- cc

ghost avatar Aug 09 '20 20:08 ghost

Got any more details?

chuckmitchell avatar Oct 02 '20 13:10 chuckmitchell

See: https://github.com/jwadhams/json-logic/issues/24

-- cc

ghost avatar Oct 11 '20 15:10 ghost

You raise a good point. Would you like to make a PR to adjust the read me to say that we currently do not support the full json logic spec at this time? I don't personally have time right now to fully implement that missing functionality, but you're right, we shouldn't be claiming we have that functionality for adding methods when we do not. I inherited this, so I was not aware we did not support more than single-argument methods, and it's a valid point.

bhgames avatar May 04 '21 03:05 bhgames

Sure... It's not going to be much though... I've really moved on from this and the project I was looking to use this on is done.

I don't do much at Github so I'll have to refresh my memory about the workflow here...and you'll have to excuse me if I violate any protocols you've established about it.

I don't understand Javascript enough to help with the code though.

-- cc

ghost avatar May 04 '21 13:05 ghost

I submitted a pull-request for the doc changes you wanted on 5/4/2021. It remains un-merged. If you're not going to merge it, please tell me. I'd like to get rid of my fork.

-- cc

ghost avatar Jun 25 '21 18:06 ghost

Hey I'll check it out!

On Fri, Jun 25, 2021 at 11:43 AM Capone Cicero @.***> wrote:

I submitted a pull-request for the doc changes you wanted on 5/4/2021. It remains un-merged. If you're not going to merge it, please tell me. I'd like to get rid of my fork.

-- cc

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bhgames/json-logic-ruby/issues/23#issuecomment-868762712, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACNA233CXG62Z4Y7GXXYIDTUTE5ZANCNFSM4PZLILPA .

--

Jordan Prince | Software Engineering O: 301.751.7354 | C: 301.751.7354

This e-mail is only intended for the person(s) to whom it is addressed and may contain confidential information. Any unauthorized review, use, disclosure, or distribution is prohibited. If you received this e-mail in error, please notify the sender by reply e-mail and then delete this message and any attachments from your system. Thank you for your cooperation.

bhgames avatar Jun 25 '21 19:06 bhgames