criterion.rs icon indicating copy to clipboard operation
criterion.rs copied to clipboard

Fix gnuplot --version encoding handling on Windows

Open sandersaares opened this issue 5 months ago • 3 comments

In some configurations, gnuplot --version will emit output as UTF-16 bytes instead of UTF-8. This is not expected by parse_version() which always expects UTF-8.

This change enhances parse_version() with a simple fallback - if UTF-8 parsing fails, it will try again with UTF-16.

Fixes #570.

sandersaares avatar Jan 25 '24 05:01 sandersaares

@bheisler @lemmih ping for attention. Would appreciate getting this merged to unblock the feature on Windows.

sandersaares avatar Feb 21 '24 06:02 sandersaares

@sandersaares If you could rebase your PR on the latest master, this would help to have a clean CI build.

samueltardieu avatar Mar 29 '24 07:03 samueltardieu

Rebased

sandersaares avatar Apr 01 '24 14:04 sandersaares