criterion.rs icon indicating copy to clipboard operation
criterion.rs copied to clipboard

Add nextest compatibility

Open sunshowers opened this issue 3 years ago • 3 comments

This commit stack makes criterion compatible with nextest using the rules listed here. Each commit is independently reviewable.

Note that none of these changes do anything special for nextest -- they just make criterion implement more of the libtest command-line interface, just enough to make nextest happy.

Addresses #562 -- once this commit stack lands and a new version of criterion goes out, I'd be happy to advertise compatibility on the nextest site.

sunshowers avatar Jul 20 '22 01:07 sunshowers

(Let me know if I should target 0.4 or master for this)

sunshowers avatar Jul 20 '22 03:07 sunshowers

This is awesome, would be great to have this reviewed and land. Wonder if there is anything blocking?

aldanor avatar Sep 04 '22 20:09 aldanor

No, the only blocker is that I have limited time and energy to spend on open-source work lately. My apologies for the delay, I'll try to get to it at some point.

bheisler avatar Sep 10 '22 18:09 bheisler

@lemmih do you think you'd be able to get a version out with this soon? Had another request come in today.

sunshowers avatar Jan 11 '23 20:01 sunshowers

Releases are managed by @bheisler.

lemmih avatar Jan 12 '23 20:01 lemmih

Hi @bheisler, do you think you'd be able to make a release soon? Thank you so much for maintaining criterion!

sunshowers avatar May 10 '23 17:05 sunshowers

Hi @bheisler, do you think you'd be able to make a release soon? Thank you so much for maintaining criterion!

Brook gave me permission to release a new version. Think you could help me update the CHANGELOG.md? We probably also want to review https://github.com/bheisler/criterion.rs/pull/679 before cutting a release.

lemmih avatar May 10 '23 19:05 lemmih

Thanks @lemmih. Happy to spend some time on this tomorrow. What would be a good way to coordinate our efforts?

sunshowers avatar May 10 '23 20:05 sunshowers

Thanks @lemmih. Happy to spend some time on this tomorrow. What would be a good way to coordinate our efforts?

If you begin updating the changelog, put the changes in a draft PR.

lemmih avatar May 10 '23 20:05 lemmih

work-in-progress updates for the changelog -> #680

nbarrios1337 avatar May 13 '23 22:05 nbarrios1337