bhaskarbhar
bhaskarbhar
@timwoj I applied function to list out backend tags in storage but then i went through your issue again, seems like a generic function to me. Am I right?
@timwoj Can you close the issue as this has been resolved. PR : https://github.com/zeek/zeek/pull/4604
@timwoj I will upload the test script for this once you approve the above, otherwise I have to write test script again if the above is not as per your...
> I think this looks great now. There's some minor indentation problems and such that we can fix during the merge. Can you squash it down to a single commit?...
@seladb While looking for this issue, I went through this function in SSLHandshake.cpp ``` SSLx509Certificate* SSLCertificateMessage::getCertificate(int index) const { if (index < 0 || index > (int)m_CertificateList.size()) { PCPP_LOG_DEBUG("certificate index...
@seladb I believe, using `index > m_CertificateList.size()` is incorrect because if `index == m_CertificateList.size()`, that index is out of bounds (since indexing is zero-based). Anyways not a big issue I...
@seladb @Dimi1010 Extremely sorry. Looks like my code has flaws in it. As I am a beginner in open source, I am making many mistakes. I will, for sure resolve...
> @bhaskarbhar why did you close the PR? 🤔 As there were many flaws I thought to go through the package.yml and correct it rather than commiting everytime. Wanted to...
@seladb @Dimi1010 checks are passed. Requesting a review.
@Dimi1010 Removed Test, corrected indentation. The **build-deb** check in **Package and Release** are passed.